Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename from containerProtoImage to protoImageName #10055

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

adlerjohn
Copy link
Contributor

@adlerjohn adlerjohn commented Sep 1, 2021

Description

Fixes #10054

Completes renaming of variables started in #9854, specifically https://github.com/cosmos/cosmos-sdk/pull/9854/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R382.

Big thanks to @evan-forbes for debugging this and proposing the correct fix.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md (N/A)
  • included comments for documenting Go code (N/A)
  • updated the relevant documentation or specification (N/A)
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, wonder if anyone uses this, if it wasn't noticed.

@tac0turtle tac0turtle merged commit 42d7e36 into cosmos:master Sep 2, 2021
@adlerjohn adlerjohn deleted the adlerjohn/fix_make_proto branch September 2, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make proto-gen uses non-existent docker container
2 participants