Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert TxFactory changes #10053

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

robert-zaremba
Copy link
Collaborator

Description

Since don't remove all legacy REST endpoints we don't need the 0155244 commit which breaks the API. Let's keep the v0.44 changes to the absolute minimum.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@orijbot
Copy link

orijbot commented Sep 1, 2021

@robert-zaremba robert-zaremba changed the base branch from master to release/v0.44.x September 1, 2021 21:43
@robert-zaremba robert-zaremba removed C:x/staking C:Keys Keybase, KMS and HSMs C:x/distribution distribution module related C:Simulations C:x/upgrade C:x/feegrant C:x/capability C:x/genutil genutil module issues C:Cosmovisor Issues and PR related to Cosmovisor labels Sep 1, 2021
@github-actions github-actions bot added the C:x/genutil genutil module issues label Sep 1, 2021
@clevinson clevinson added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 1, 2021
@robert-zaremba robert-zaremba merged commit 59a4952 into release/v0.44.x Sep 1, 2021
@robert-zaremba robert-zaremba deleted the robert/revert-v044 branch September 1, 2021 21:58
@amaury1093 amaury1093 added this to the v0.44.1 milestone Sep 29, 2021
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Oct 12, 2021
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)"

This reverts commit 0155244.

* remove conflict marks from changelog

* update changelog
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Nov 1, 2021
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)"

This reverts commit 0155244.

* remove conflict marks from changelog

* update changelog
Eengineer1 pushed a commit to cheqd/cosmos-sdk that referenced this pull request Aug 26, 2022
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)"

This reverts commit 0155244.

* remove conflict marks from changelog

* update changelog
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)"

This reverts commit 0155244.

* remove conflict marks from changelog

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants