Fix: unmarshalling issue with multisig keys in v0.42.x #10043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasted
requested review from
aaronc,
alessio and
alexanderbez
as code owners
|
I have tested this on master and fails too, so it is not specific to 0.42 @aaronc @robert-zaremba @AmauryM |
| @@ -380,4 +381,5 @@ func TestAminoUnmarshalJSON(t *testing.T) { | |||
| err := cdc.UnmarshalJSON([]byte(pkJSON), &pk) | |||
| require.NoError(t, err) | |||
| require.Equal(t, uint32(3), pk.(*kmultisig.LegacyAminoPubKey).Threshold) | |||
| require.Equal(t, 5, len(pk.(*kmultisig.LegacyAminoPubKey).PubKeys)) | |||
There was a problem hiding this comment.
Could you add a check for the content of individual keys?
|
Since the bug is in |
|
Retargetting doesn't work, because your PR is based on a wrong branch. Could you cherry pick your commit in a new branch based on latest master and reset the branch and change the target please? |
|
also, you should lint the code |
19 tasks
|
I have created #10061 to target the |
|
done by #10113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10042
This fixes the issue outlined in #10042: The
LegacyAminoPubKeystruct fails to correctly unmarshal from JSON.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change