Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding pre-upgrade command call in Cosmovisor #10006

Closed
wants to merge 6 commits into from

Conversation

spoo-bar
Copy link
Contributor

Description

Closes: #9973

Cosmosvisor calls pre-upgrade command on the application before upgrade


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@spoo-bar spoo-bar added the C:Cosmovisor Issues and PR related to Cosmovisor label Aug 25, 2021
@spoo-bar spoo-bar requested review from anilcse and jgimeno August 25, 2021 10:54
cosmovisor/process.go Outdated Show resolved Hide resolved
cosmovisor/process.go Outdated Show resolved Hide resolved
@orijbot
Copy link

orijbot commented Sep 1, 2021

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #10006 (4c6f966) into master (6bddcd5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10006   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files         572      572           
  Lines       53584    53584           
=======================================
+ Hits        34058    34059    +1     
+ Misses      17583    17582    -1     
  Partials     1943     1943           
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@spoo-bar
Copy link
Contributor Author

spoo-bar commented Sep 2, 2021

Closing in favour of #10056

@spoo-bar spoo-bar closed this Sep 2, 2021
@julienrbrt julienrbrt deleted the spoorthi/9973-cosmovisor-preupgrade branch May 18, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pre-upgrade command in Cosmovisor
4 participants