Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add []sdk.Msg to gov proposal #9865

Closed
aaronc opened this issue Aug 6, 2021 · 0 comments · Fixed by #10763
Closed

Add []sdk.Msg to gov proposal #9865

aaronc opened this issue Aug 6, 2021 · 0 comments · Fixed by #10763

Comments

@aaronc
Copy link
Member

aaronc commented Aug 6, 2021 •
edited by amaury1093
Loading

Add Any to v1beta2's MsgSubmitProposal that represent the sdk.Msg to be executed.
@github-actions github-actions bot added the stale label Sep 21, 2021
@clevinson clevinson removed the stale label Oct 1, 2021
@amaury1093 amaury1093 mentioned this issue Dec 16, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #10763 Dec 16, 2021
mergify bot pushed a commit that referenced this issue Dec 16, 2021
@cmwaters
refactor!: move v1beta2 gov types into types dir (#10763)
350f916 
closes #9865 

To be merged after #10748

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: move v1beta2 gov types into types dir cosmos/cosmos-sdk
2 participants
@aaronc @clevinson