Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MsgWithdrawProposal to group module #9660

Closed
4 tasks
blushi opened this issue Jul 9, 2021 · 0 comments · Fixed by #10893
Closed
4 tasks

Add MsgWithdrawProposal to group module #9660

blushi opened this issue Jul 9, 2021 · 0 comments · Fixed by #10893
Assignees
@atheeshp
Labels
C:x/group S:proposed T:feature-request

Comments

@blushi
Copy link
Contributor

blushi commented Jul 9, 2021

Summary

Add ability to withdraw a group proposal
ref: regen-network/cosmos-modules#41

Problem Definition

It might be useful to be able to cancel/withdraw a proposal because its content is not valid and/or the group members don't want it to be executed anymore (without the need to individually reject it via MsgVote).

Proposal

Add MsgWithdrawProposal:

message MsgWithdrawProposal {
  string admin = 1;
  uint64 proposal_id = 2;
}

where admin is the admin of the group account.
We could also allow any proposers of the proposal to withdraw it. Thoughts? @aaronc @frumioj @ryanchristo

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@blushi blushi mentioned this issue Jul 9, 2021
Merged
19 tasks
@github-actions github-actions bot added the stale label Aug 24, 2021
@blushi blushi reopened this Aug 30, 2021
@github-actions github-actions bot closed this as completed Sep 6, 2021
@blushi blushi reopened this Sep 6, 2021
@blushi blushi removed the stale label Sep 6, 2021
@atheeshp atheeshp self-assigned this Jan 4, 2022
@atheeshp atheeshp mentioned this issue Jan 6, 2022
Merged
19 tasks
@mergify mergify bot closed this as completed in #10893 Feb 4, 2022
mergify bot pushed a commit that referenced this issue Feb 4, 2022
@atheeshp
feat: add MsgWithdrawProposal to group module (#10893)
b9c7fd1 
## Description

Closes: #9660 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
C:x/group S:proposed T:feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add MsgWithdrawProposal to group module cosmos/cosmos-sdk
3 participants
@blushi @alexanderbez @atheeshp