[Bug] feegrant grant cli is not working due to unnecessary address check

[yun-yeo]

Summary of Bug

errors happens like

$ terrad tx feegrant grant terra1t849fxw7e8ney35mxemh4h3ayea4zf77dslwna terra1ucp369yry6n70qq3zaxyt85cnug75r7ln8l6se --spend-limit 1000000uluna --expiration 2022-01-01T00:00:00Z --from tmp --chain-id testnet
Error: key with address59EA5499DEC9E792469B36777ADE3D267B5127DEnot found: key not found

cosmos-sdk/x/feegrant/client/cli/tx.go

Lines 66 to 68 in d13d488

	_, err := sdk.AccAddressFromBech32(args[0])
	if err != nil {
	return err

These lines are unnecessary because it will enforce to use only address as granter argument and, in the next few lines, it set arg[0] to FlagFrom which is enforcing to use key name as granter argument unless --generate-only option activated.

cosmos-sdk/x/feegrant/client/cli/tx.go

Line 71 in d13d488

cmd.Flags().Set(flags.FlagFrom, args[0])

Version

v0.43.0-rc0

Steps to Reproduce

use feegrant cli

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[likhita-809]

These lines are unnecessary because it will enforce to use only address as granter argument and, in the next few lines, it set arg[0] to FlagFrom which is enforcing to use key name as granter argument unless --generate-only option activated.

@YunSuk-Yeo As you can see here

cosmos-sdk/x/feegrant/client/cli/tx.go

Lines 53 to 54 in d13d488

	`Grant authorization to pay fees from your address. Note, the'--from' flag is
	ignored as it is implied from [granter].

, --from flag is ignored and it is implied from granter. So it makes sense to use this way

cosmos-sdk/x/feegrant/client/cli/tx.go

Line 71 in d13d488

cmd.Flags().Set(flags.FlagFrom, args[0])

And do you mean to use key name as argument for granter by this line These lines are unnecessary because it will enforce to use only address as granter argument ?

[likhita-809]

These lines are unnecessary because it will enforce to use only address as granter argument and, in the next few lines, it set arg[0] to FlagFrom which is enforcing to use key name as granter argument unless --generate-only option activated.

@YunSuk-Yeo As you can see here

cosmos-sdk/x/feegrant/client/cli/tx.go

Lines 53 to 54 in d13d488

	`Grant authorization to pay fees from your address. Note, the'--from' flag is
	ignored as it is implied from [granter].

, --from flag is ignored and it is implied from granter. So it makes sense to use this way

cosmos-sdk/x/feegrant/client/cli/tx.go

Line 71 in d13d488

cmd.Flags().Set(flags.FlagFrom, args[0])

And do you mean to use key name as argument for granter by this line These lines are unnecessary because it will enforce to use only address as granter argument ?

@YunSuk-Yeo can you give your response on this ?

[yun-yeo]

@likhita-809 Please try run with simd binary, it also raise error

Yea I agree to use this line

cosmos-sdk/x/feegrant/client/cli/tx.go

Line 71 in d13d488

cmd.Flags().Set(flags.FlagFrom, args[0])

Just need to remove this address validation check.

cosmos-sdk/x/feegrant/client/cli/tx.go

Lines 66 to 68 in d13d488

	_, err := sdk.AccAddressFromBech32(args[0])
	if err != nil {
	return err

The above lines are enforcing to use address not key name as arg[0].

Also the below line set arg[0] to --from flag, which is supposed to be key name without --generate-only flag.

cosmos-sdk/x/feegrant/client/cli/tx.go

Line 71 in d13d488

cmd.Flags().Set(flags.FlagFrom, args[0])

The arg[0] (== --from) is supposed to be

• key name in normal case
• address when --generate-only set

without --generate-only flag it returns always error due to the above address validation check.