-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MsgLeaveGroup to group module #9657
Comments
Is "logout" the same as "leave group"? Why? |
A group admin is not necessarily part of the group members. But a group admin can update the group with a new admin. |
The first option would be the most straightforward to implement for now but then I agree this could come with a bad UX because that would require the group account admin to update the decision policy beforehand. |
## Description Closes: #9657 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Summary
An ability for a member to unilaterally leave a group.
Problem Definition
Normally in a social group, if one member decides to leave a group, they simply can. Nobody else needs to agree.
Also, if I am using a group to manage a single wallet with multiple keys. I would like the ability to "log out" of one device without needing the other devices to approve.
Proposal
Add
MsgLeaveGroup
:One difficulty with implementing this is that it could make
ThresholdDecisionPolicy
fail if there are not enough members to meet the threshold if a member leaves. To address this, we either need to:For Admin Use
The text was updated successfully, but these errors were encountered: