Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init command should fetch chain id from config #9604

Closed
4 tasks
fedekunze opened this issue Jun 29, 2021 · 1 comment · Fixed by #9762
Closed
4 tasks

init command should fetch chain id from config #9604

fedekunze opened this issue Jun 29, 2021 · 1 comment · Fixed by #9762
Assignees
@ryanchristo

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Jun 29, 2021 •
edited
Loading

Summary of Bug

if not provided, the init command should fetch the chain id from the config before failing

Version

v0.43.0-rc0

Steps to Reproduce

  • set chain id using

<app>d config chain-id $CHAINID

  • initialize chain using init (without chain id)

<appd> init $MONIKER

Error: invalid chain-id format: 
Usage:
  ethermintd init [moniker] [flags]

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze
Copy link
Collaborator Author

probably affects a few other commands

@ryanchristo ryanchristo self-assigned this Jul 24, 2021
@ryanchristo ryanchristo mentioned this issue Jul 24, 2021
Merged
19 tasks
@mergify mergify bot closed this as completed in #9762 Jul 26, 2021
mergify bot pushed a commit that referenced this issue Jul 26, 2021
@ryanchristo
fix: init with config chain-id (#9762)
f4d0682 
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: #9604, Ref: #9644

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

The `init` command uses the `chain-id` from the client config if `--chain-id` is not provided.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) -n/a
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc) -n/a
- [x] updated the relevant documentation or specification -n/a
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanchristo ryanchristo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: init with config chain-id cosmos/cosmos-sdk
2 participants
@ryanchristo @fedekunze