Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring: remove package dependency replacement once fix is merged in 99designs/keyring#87 #9568

Closed
4 tasks done
robert-zaremba opened this issue Jun 23, 2021 · 2 comments · Fixed by #12576
Closed
4 tasks done

keyring: remove package dependency replacement once fix is merged in 99designs/keyring#87 #9568

robert-zaremba opened this issue Jun 23, 2021 · 2 comments · Fixed by #12576
Assignees
@robert-zaremba
Labels
C:Keys Keybase, KMS and HSMs dependencies Pull requests that update a dependency file
Milestone
Feature Backlog

Comments

@robert-zaremba
Copy link
Collaborator

Summary

In #9563 we added a replacement for 99designs/keyring. Once the 99designs/keyring#87 is merged, we should remove the replacement and bump the version.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added C:Keys Keybase, KMS and HSMs dependencies Pull requests that update a dependency file labels Jun 23, 2021
@robert-zaremba robert-zaremba added this to the Feature Backlog milestone Jun 23, 2021
@robert-zaremba robert-zaremba self-assigned this Jun 23, 2021
@tomtau
Copy link
Contributor

tomtau commented Jul 7, 2021

Not sure if keyring is maintained -- we had another fix: 99designs/keyring#83 (without the fix, keyring won't work for libsecret with any Cosmos SDK apps that have dashes in their names).

Plus, some other desirable functionality is blocked by it, e.g.: 99designs/keyring#85

Perhaps an alternative proposal would be to bite the bullet and vendor in its code to Cosmos SDK or maintain https://github.com/cosmos/keyring long-term?

@github-actions github-actions bot added the stale label Aug 22, 2021
@tomtau
Copy link
Contributor

tomtau commented Oct 11, 2021

both PRs were merged

rootulp added a commit to rootulp/cosmos-sdk that referenced this issue Jul 14, 2022
@rootulp
Remove cosmos/keyring
0b3e60e 
The `replace` for 99designs/keyring to a Cosmos fork of keyring
(cosmos/keyring) was added in cosmos#9563

Removal of the `replace` was tracked in cosmos#9568
but never completed.

The original issue was fixed in upstream: 99designs/keyring#87
so this PR removes the `replace` and upgrades to the latest release of
99designs/keyring.
@rootulp rootulp mentioned this issue Jul 14, 2022
Merged
19 tasks
@julienrbrt julienrbrt reopened this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

Labels
C:Keys Keybase, KMS and HSMs dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Feature Backlog
Development

Successfully merging a pull request may close this issue.

refactor: remove cosmos/keyring rootulp/cosmos-sdk
3 participants
@robert-zaremba @tomtau @julienrbrt