Keep or remove SDK crypto.Address

[robert-zaremba]

Summary

SDK /crypto/types.Address is an alias to tendermint crypto.Address.

Problem Definition

Type aliases are used for refactoring or when there is a need for moving a type in a local scope (usually using a private types). Otherwise they bring zero value. We end up with a dead type which we can't customize.

Proposal

Remove SDK Address. Otherwise provide justification for keeping the type alias. In the latter case - update SDK consistently to use SDK Address

Related to:

• Remove store type aliases in /types #9362

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[robert-zaremba]

cc: @aaronc , @AmauryM , @alessio , @alexanderbez - What do you think about removing the type alias. It's a quick thing, removes disambiguation.

[aaronc]

We actually want the SDK's PubKey type to not have a dependency on tendermint. So I actually think we want to make the type alias a proper type and independent of tendermint.

[robert-zaremba]

We have many dependencies to tendermint. If the interface is good, why we would need to create an alias? Other, better approach would be to extend the interface when needed, eg:

type Address interface {
  tmcrypto.Address

  SomethingExtra()
}

[robert-zaremba]

In general - we should avoid changing interfaces when possible.

[aaronc]

We wanted to diverge from the TM PubKey for a variety of reasons. There are prior issues you can find where this was discussed. I think we should stay on that course.

[aaronc]

That said maybe there's no need to do anything about Address

[robert-zaremba]

Currently in SDK we are using both tmcrypto.Address and sdkcrypto.Address. Changing an interface is a breaking change and will require more work anyway. There is a chance that most of the user code could work with tmcrypto.Address if we only extend the interface and use won't use the extensions. So my preference would be to remove the alias and do a new type once needed.

[robert-zaremba]

@alessio , @alexanderbez - do you have an opinion here?

[alessio]

This

cosmos-sdk/crypto/types/types.go

Line 42 in e73cf2b

Address = tmcrypto.Address

is an alias of tmcrypto.Address, which in turn is an alias of HexBytes:

type Address = bytes.HexBytes

Yes, let's remove github.coms/cosmos/cosmos-sdk/crypto.Address, please.

[robert-zaremba]

Shall we include it in 0.44?