Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure the REST API == CLI commands #585

Closed
zramsay opened this issue Mar 5, 2018 · 1 comment
Closed

ensure the REST API == CLI commands #585

zramsay opened this issue Mar 5, 2018 · 1 comment

Comments

@zramsay
Copy link
Contributor

zramsay commented Mar 5, 2018

ref: cosmos/gaia#103
@ebuchman
Copy link
Member

closing for #629

yihuang pushed a commit to yihuang/cosmos-sdk that referenced this issue Jul 22, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
5972d50
dudong2 pushed a commit to b-harvest/cosmos-sdk that referenced this issue Oct 23, 2024
@mmsqe @dudong2
Problem: snapshot for object store is not skipped (cosmos#585)
9692120
dudong2 pushed a commit to b-harvest/cosmos-sdk that referenced this issue Oct 30, 2024
@mmsqe @dudong2
Problem: snapshot for object store is not skipped (cosmos#585)
ad69ee0
dudong2 added a commit to b-harvest/cosmos-sdk that referenced this issue Nov 6, 2024
@dudong2 @yihuang
@mmsqe @cloudgray
feat: apply cronos store (#207)
a25eb3a 
* Support object store (#206)

generic interface

generic btree

generic cachekv

generic transient store

support ObjStore

changelog

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

object store key

Apply review suggestions

fix merge conflict

fix snapshot

revert dependers

* Problem: CacheWrapWithTrace api is not used (#207)

Solution:
- remove the api

changelog

* prefix store support object store (#236)

* Problem: MultiStore interface is bloated (#240)

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* Problem: nested cache store not efficient (#241)

* Problem: nested cache store not efficient

Solution:
- introduce copy-on-write btree based cache store

temp

* changelog

* rename

* Update store/cachekv/store.go

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* Problem: many memory allocs in cache store wrapping (#242)

Solution:
- init cachestore on cachestore lazily.
- cleanup some unused stuff.

Update store/CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Problem: no API to use the new CoW branch store (#243)

* Support RunAtomic API

* add unit test

* Problem: store key type assertion is incorrect (#244)

fix and add test

* Problem: Restore don't work snapshot revert usage (#245)

Solution:
- fix and add test to support the usage pattern in ethermint

add Discard method to CacheWrap

better testing

* feat: save some memory allocations on un-used cache store (#248)

* feat: save some memory allocations on un-used cache store

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update store/internal/btree/btree.go

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* Problem: no api to create cachemulti store from external cache store (#258)

Solution:
- add API NewFromParent to cache multistore.

Update store/CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

fix test

fix lint

* Problem: snapshot for object store is not skipped (cosmos#585)

* Problem: versiondb/memiavl don't compatible with upstream sdk (cosmos#588)

* Problem: versiondb/memiavl don't compatible with upstream sdk

Solution:
- avoid api breaking change

* fix build

* chore: Update test.yml go version 1.21

* chore: fix lint

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Kyuhyeon Choi <[email protected]>
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this issue Dec 12, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
b01be76
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this issue Dec 12, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
9ddbff1
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this issue Dec 16, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
6baa149
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this issue Dec 16, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
db049c4
dudong2 added a commit to b-harvest/cosmos-sdk that referenced this issue Dec 17, 2024
@dudong2 @yihuang
@mmsqe @cloudgray
feat: apply cronos store (#207)
fab9101 
* Support object store (#206)

generic interface

generic btree

generic cachekv

generic transient store

support ObjStore

changelog

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

object store key

Apply review suggestions

fix merge conflict

fix snapshot

revert dependers

* Problem: CacheWrapWithTrace api is not used (#207)

Solution:
- remove the api

changelog

* prefix store support object store (#236)

* Problem: MultiStore interface is bloated (#240)

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* Problem: nested cache store not efficient (#241)

* Problem: nested cache store not efficient

Solution:
- introduce copy-on-write btree based cache store

temp

* changelog

* rename

* Update store/cachekv/store.go

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* Problem: many memory allocs in cache store wrapping (#242)

Solution:
- init cachestore on cachestore lazily.
- cleanup some unused stuff.

Update store/CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Problem: no API to use the new CoW branch store (#243)

* Support RunAtomic API

* add unit test

* Problem: store key type assertion is incorrect (#244)

fix and add test

* Problem: Restore don't work snapshot revert usage (#245)

Solution:
- fix and add test to support the usage pattern in ethermint

add Discard method to CacheWrap

better testing

* feat: save some memory allocations on un-used cache store (#248)

* feat: save some memory allocations on un-used cache store

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update store/internal/btree/btree.go

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* Problem: no api to create cachemulti store from external cache store (#258)

Solution:
- add API NewFromParent to cache multistore.

Update store/CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

fix test

fix lint

* Problem: snapshot for object store is not skipped (cosmos#585)

* Problem: versiondb/memiavl don't compatible with upstream sdk (cosmos#588)

* Problem: versiondb/memiavl don't compatible with upstream sdk

Solution:
- avoid api breaking change

* fix build

* chore: Update test.yml go version 1.21

* chore: fix lint

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Kyuhyeon Choi <[email protected]>
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this issue Dec 18, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
36fcfe1
dudong2 added a commit to b-harvest/cosmos-sdk that referenced this issue Dec 19, 2024
@dudong2 @yihuang
@mmsqe @cloudgray
feat: apply cronos store (#207) (#380)
7fb019e 
* Support object store (#206)

generic interface

generic btree

generic cachekv

generic transient store

support ObjStore

changelog

Update CHANGELOG.md



object store key

Apply review suggestions

fix merge conflict

fix snapshot

revert dependers

* Problem: CacheWrapWithTrace api is not used (#207)

Solution:
- remove the api

changelog

* prefix store support object store (#236)

* Problem: MultiStore interface is bloated (#240)

* Problem: MultiStore interface is bloated

Solution:
- Split out specialied methods from it, keeping the MultiStore generic

* Update store/CHANGELOG.md



---------



* Problem: nested cache store not efficient (#241)

* Problem: nested cache store not efficient

Solution:
- introduce copy-on-write btree based cache store

temp

* changelog

* rename

* Update store/cachekv/store.go



---------



* Problem: many memory allocs in cache store wrapping (#242)

Solution:
- init cachestore on cachestore lazily.
- cleanup some unused stuff.

Update store/CHANGELOG.md



* Problem: no API to use the new CoW branch store (#243)

* Support RunAtomic API

* add unit test

* Problem: store key type assertion is incorrect (#244)

fix and add test

* Problem: Restore don't work snapshot revert usage (#245)

Solution:
- fix and add test to support the usage pattern in ethermint

add Discard method to CacheWrap

better testing

* feat: save some memory allocations on un-used cache store (#248)

* feat: save some memory allocations on un-used cache store

* Update CHANGELOG.md



* Update store/internal/btree/btree.go



---------



* Problem: no api to create cachemulti store from external cache store (#258)

Solution:
- add API NewFromParent to cache multistore.

Update store/CHANGELOG.md



fix test

fix lint

* Problem: snapshot for object store is not skipped (cosmos#585)

* Problem: versiondb/memiavl don't compatible with upstream sdk (cosmos#588)

* Problem: versiondb/memiavl don't compatible with upstream sdk

Solution:
- avoid api breaking change

* fix build

* chore: Update test.yml go version 1.21

* chore: fix lint

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Kyuhyeon Choi <[email protected]>
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this issue Dec 31, 2024
@mmsqe
Problem: snapshot for object store is not skipped (cosmos#585)
0dc83a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebuchman @zramsay