Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AppTx to have "Type" field be of String type, not byte. #4

Closed
jaekwon opened this issue Dec 21, 2016 · 2 comments
Closed

Change AppTx to have "Type" field be of String type, not byte. #4

jaekwon opened this issue Dec 21, 2016 · 2 comments

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Dec 21, 2016

It's a few extra bytes per transaction, but I think the legibility is worth it.
@ethanfrey
Copy link
Contributor

I think one byte is a bit harsh. But a string is a bit much. Maybe use [8]byte there, and then you can use any 8 characters for legibility. "governmt" is more legible than 0x02, and less likely to have accidental conflicts.

Why 8 bytes? Cuz with 64-bit architectures almost everything ends up padded to 8-byte intervals, so this shouldn't take up much more space. Although 4 bytes should be enough for semi-legability.

@ebuchman
Copy link
Member

Looks like this has been changed to Name string for a while

liamsi pushed a commit to liamsi/cosmos-sdk that referenced this issue Jun 26, 2018
@ebuchman
Merge pull request cosmos#4 from tendermint/develop
3f47cfa 
go-data support
liamsi pushed a commit to liamsi/cosmos-sdk that referenced this issue Jun 26, 2018
@ethanfrey
Merge pull request cosmos#4 from tendermint/glide
07ac320 
Added glide dependency handling
@jackzampolin jackzampolin mentioned this issue Jul 24, 2018
Merged
dogemos referenced this issue in dogemos/cosmos-sdk Apr 9, 2020
@dogemos
Merge pull request #4 from cosmos/develop
22b8d0f 
Sync fork with cosmos develop
ulbqb pushed a commit to ulbqb/cosmos-sdk that referenced this issue Jun 8, 2023
@Manav-Aggarwal
feat: Fraud Proof Verification using IAVL Deep Subtrees (cosmos#4)
e1448e7 
* Replace tendermint with celestiaorg tendermint version

* Add new ABCI method skeleton: build works now

* Add fraudproof data structure

* Add helper methods to baseapp test for fraudproofs

* Add TODOs in baseapp test method

* Add SetupBaseParams with SMT, WIP to IAVL

* Add tracekv readOperations and getAllKeysUsedInTrace

* Cleanup errors

* Add loadLastVersion to IAVL rootmulti store

* Remove enableFraudProofGenerationMode

* Add substore tracing to rootmulti store

* Add ability to reset trace writer buffers after each commit

* Able to get the trace made by fraudulent state transition now

* Start writing getFraudProof method in BaseApp

* Substitute SMT with IAVL trees inside getFraudProof

* Implement getStoreProof inside rootmulti store

* Completed generateFraudProof with IAVL store

* Remove routerOpts from baseapp test when generating fraud proofs

* Switch out proof decoder

* Add Root in IAVL to use working hash instead of lastCommitID hash

* Fix getAppHash to use working hashes of IAVL stores

* Implement ABCI method to verify fraud proofs

* Start setup BaseApp from IAVL store WIP

* Add option to SetInitialHeight

* Initialize baseapp from IAVL trees

* Use deepIAVLTree in loadVersion

* Add SetTracerFor to mock store

* Add gdocs to new ABCI methods

* Refactor from fmt.errorf into errors.New

* Update error packages used

* Update docs to remove SMT references

* Add unit test for checkFraudulentStateTransition

* modify executeNonFraudulentStateTransactions to accomodate case when EndBlock is fraudulent

* Refactor code

* add deepsubtrees version of iavl

* add getDSTProof in iavl store WIP

* Add non-existence DST proofs

* Change getDeepIAVLTrees to use new DST

* Use deepsubtree as interface and use version constructor

* Support unused modules

* Minor changes to make tests pass

* Replicate trace buffers before fast forwarding tx again

* Don't export SetupBaseAppFromParams

* Refactor populateStateWitness out

* refactor options.go dependencies
MSalopek pushed a commit to MSalopek/cosmos-sdk that referenced this issue Nov 22, 2023
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (cosmos#4)
a5d108b 
* Fix lint/gocritic error

* Disable some workflow jobs
nivasan1 pushed a commit to nivasan1/cosmos-sdk that referenced this issue Feb 13, 2024
@prettymuchbryce @lcwik
Enable CI workflows and fix failures (cosmos#4)
b92c2ff 
* Fix lint/gocritic error

* Disable some workflow jobs
ezreal1997 pushed a commit to ezreal1997/cosmos-sdk that referenced this issue Oct 19, 2024
@0xHansLee
feat(staking): make staking keeper endblocker return unbonded entry (c…
77940b3 
…osmos#4)

* chore(staking): add error log when unbonding and redelegation failed

* feat(staking): make staking keeper endblocker return unbonded entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaekwon @ebuchman @ethanfrey