Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Consistent Operators #3679

Merged
merged 9 commits into from
Feb 21, 2019
Merged

R4R: Consistent Operators #3679

merged 9 commits into from
Feb 21, 2019

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Feb 19, 2019

closes #2360

Find replace changes made to go files:

  • Minus -> Sub
  • Plus -> Add
  • Div -> Quo

Post replace fixes:

  • Quoision -> Division

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3679 into develop will decrease coverage by 0.01%.
The diff coverage is 82.19%.

@@            Coverage Diff             @@
##           develop   #3679      +/-   ##
==========================================
- Coverage    61.21%   61.2%   -0.02%     
==========================================
  Files          190     190              
  Lines        13995   13995              
==========================================
- Hits          8567    8565       -2     
- Misses        4892    4894       +2     
  Partials       536     536

@rigelrozanski rigelrozanski changed the title WIP: Consistent Operators R4R: Consistent Operators Feb 19, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the dirty work 💪

PENDING.md Outdated Show resolved Hide resolved
@alexanderbez alexanderbez added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Feb 19, 2019
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold this off - I'm happy to incorporate these changes in #3678. If this is approved it will make my branch stale and will give me quite some pain

@rigelrozanski
Copy link
Contributor Author

@alessio - would you like me push the relevant changes to your branch? It will literally take me 1 minute

Co-Authored-By: rigelrozanski <[email protected]>
@alessio
Copy link
Contributor

alessio commented Feb 19, 2019

@rigelrozanski that'd be greatly appreciated!

@rigelrozanski
Copy link
Contributor Author

@alessio merge at will: #3687

@rigelrozanski rigelrozanski merged commit a814e5c into develop Feb 21, 2019
@rigelrozanski rigelrozanski deleted the rigel/consistent-operators branch February 21, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent use of Plus vs Add etc.
3 participants