Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Multiple Coins #24

Closed
rigelrozanski opened this issue Feb 9, 2017 · 3 comments · Fixed by #26
Closed

CLI Multiple Coins #24

rigelrozanski opened this issue Feb 9, 2017 · 3 comments · Fixed by #26

Comments

@rigelrozanski
Copy link
Contributor

This issue is intended to be a discussion space surrounding sending transaction coins through the CLI. Currently there are three transaction fields using coins:

  • coin: string identifier for the coin type
  • fee: integer containing the fee
  • amount: integer containing the amount to send in the transaction

Problems with this current setup:

  • only allows for one coin type for the fee
  • only allows for one coin type for the transaction amount
  • type of coin must be the same for the transaction as well as the fee

Initial proposed solution: hack it with slashes. Rather than having fee and amount be integer types, we could make them strings which we parse at execution, this would of course limit the use of the slash character within the coin-type name if operating from the CLI. This would also eliminate the need for the coin flag, as it would be built right into fee or amount. Here are some examples that could be valid strings to send into the proposed fee or amount flags:

blank/1/btc/2
gold/10
atoms/10/btc/100/silver/666
etc.

The intention of using this is to simplify use of the CLI so the user doesn't need to point to a .json file nor type any json code. Thoughts?

@ebuchman
Copy link
Member

ebuchman commented Feb 9, 2017

what about this as a format: atoms:10,btc:100,silver:666

@mappum
Copy link
Contributor

mappum commented Feb 9, 2017

What if we even limit the coin names not to include numbers so we could do
this: 10atom,100btc,666silver. Add we could support spaces so if you
quote your CLI arg you could do this: "10 ATOM, 100 BTC".

@ebuchman
Copy link
Member

ebuchman commented Feb 9, 2017 via email

liamsi pushed a commit to liamsi/cosmos-sdk that referenced this issue Jun 26, 2018
Add a godoc reference to delegate indexing and references
to that service, thus keeping our library and usages upto date,
instead of relying on generated markdown that goes stale
especially for changing API signatures, and becomes tedious
where someone has to remember to always regenerate the README
markdown and then commit it.

Fixes cosmos#24
sosedoff referenced this issue in figment-networks/cosmos-sdk May 16, 2022
* use memdb for cachekv

* Remove remaining n^2 nature of CacheKV (Speedup dirtyItems)

* Delete deadcode, fix lint

Co-authored-by: mconcat <[email protected]>
luchenqun pushed a commit to luchenqun/cosmos-sdk that referenced this issue Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants