We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AccountMapper.IterateAccounts may leak resource.
cosmos-sdk/x/auth/mapper.go
Line 89 in d5652d9
almost all of Iterator implement is trival,but iavlIterator.Close is no-trival. see
cosmos-sdk/store/iavlstore.go
Line 372 in d5652d9
in democoin/oracle/handle.go also has a similar case,but it's a full iterator,here only cause confusion,not incorrect.
cosmos-sdk/examples/democoin/x/oracle/handler.go
Line 30 in bce0905
This Issue is base on tag v0.24.0
The text was updated successfully, but these errors were encountered:
Your totally right! Thanks for catching this. Would you like to submit a PR to fix this?
Sorry, something went wrong.
fix Iterator leak, ref to cosmos#2105
517682f
Modify PENDING.md for cosmos#2105
e04e524
Successfully merging a pull request may close this issue.
Summary of Bug
AccountMapper.IterateAccounts may leak resource.
Steps to Reproduce
cosmos-sdk/x/auth/mapper.go
Line 89 in d5652d9
Iterator need to Close after use,this may leak a go routine for iavlIterator.
almost all of Iterator implement is trival,but iavlIterator.Close is no-trival.
see
cosmos-sdk/store/iavlstore.go
Line 372 in d5652d9
in democoin/oracle/handle.go also has a similar case,but it's a full iterator,here only cause confusion,not incorrect.
cosmos-sdk/examples/democoin/x/oracle/handler.go
Line 30 in bce0905
This Issue is base on tag v0.24.0
For Admin Use
The text was updated successfully, but these errors were encountered: