Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missing gcc error message to hint at disabling ledger support. #2005

Closed
ValarDragon opened this issue Aug 13, 2018 · 2 comments
Closed

Update missing gcc error message to hint at disabling ledger support. #2005

ValarDragon opened this issue Aug 13, 2018 · 2 comments
Assignees
@ValarDragon
Labels
good first issue help wanted T: UX

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Aug 13, 2018 •
edited by alexanderbez
Loading 

make get_vendor_deps
Makefile:21: *** "gcc not installed for ledger support, please install".  Stop.

We should probably make the error message suggest disabling the LEDGER_SUPPORT in the Makefile for a better and more clear UX.
@cwgoes
Copy link
Contributor

cwgoes commented Aug 13, 2018

Are you building with Ledger support disabled?

@ValarDragon
Copy link
Contributor Author

Ah, no I was using the default makefile. Thanks, that did fix it. We should probably make the error message suggest disabling the LEDGER_SUPPORT line in the makefile.

@alexanderbez alexanderbez changed the title gcc is required to run any makefile commands Update missing gcc error message to hint at disabling ledger support. Aug 13, 2018
@ValarDragon ValarDragon self-assigned this Aug 13, 2018
ValarDragon added a commit that referenced this issue Aug 13, 2018
@ValarDragon
makefile: Improve error message when LEDGER_ENABLED=True & no gcc
551991f 
Closes #2005
@ValarDragon ValarDragon mentioned this issue Aug 13, 2018
Merged
3 tasks
cwgoes pushed a commit that referenced this issue Aug 13, 2018
@ValarDragon @cwgoes
makefile: Improve error message when LEDGER_ENABLED=True & no gcc (#2008
1854430 
)

Closes #2005
fedekunze pushed a commit that referenced this issue Aug 15, 2018
@ValarDragon
makefile: Improve error message when LEDGER_ENABLED=True & no gcc (#2008
478c60e 
)

Closes #2005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValarDragon ValarDragon

Labels
good first issue help wanted T: UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @cwgoes