Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please turn indexing on by default. #1930

Closed
4 tasks done
NodeGuy opened this issue Aug 7, 2018 · 4 comments
Closed
4 tasks done

Please turn indexing on by default. #1930

NodeGuy opened this issue Aug 7, 2018 · 4 comments
Assignees
Labels

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 7, 2018

Summary

Make the default configuration value for whether a node performs indexing to betrue.

Problem Definition

Voyager needs indexing nodes to show transaction history so more indexing nodes are better. There are no real disadvantages since it can be turned off.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@cwgoes
Copy link
Contributor

cwgoes commented Aug 8, 2018

(this is in config.toml)

@ValarDragon
Copy link
Contributor

@alessio
Copy link
Contributor

alessio commented Aug 9, 2018

The config.toml generated by gaiad init contains the following stanza:

##### transactions indexer configuration options #####
[tx_index]

# What indexer to use for transactions
#
# Options:
#   1) "null" (default)
#   2) "kv" - the simplest possible indexer, backed by key-value storage (defaults to levelDB; see DBBackend).
indexer = "kv"

# Comma-separated list of tags to index (by default the only tag is tx hash)
#
# It's recommended to index only a subset of tags due to possible memory
# bloat. This is, of course, depends on the indexer's DB and the volume of
# transactions.
index_tags = ""

# When set to true, tells indexer to index all tags. Note this may be not
# desirable (see the comment above). IndexTags has a precedence over
# IndexAllTags (i.e. when given both, IndexTags will be indexed).
index_all_tags = false

It seems indexing is on by default, i.e. indexer = "kv"

@cwgoes
Copy link
Contributor

cwgoes commented Aug 9, 2018

It seems indexing is on by default, i.e. indexer = "kv"

We need to additionally specify index_all_tags = true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants