Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable indexing of all tags by default #1948

Merged
merged 2 commits into from
Aug 10, 2018
Merged

enable indexing of all tags by default #1948

merged 2 commits into from
Aug 10, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 9, 2018 •
edited by ValarDragon
Loading

Closes #1930

@faboweb
Copy link
Contributor

faboweb commented Aug 9, 2018

@cosmos/cosmos-ui FYI

@cwgoes
Copy link
Contributor

cwgoes commented Aug 9, 2018

@alessio Change looks fine - can we add an entry in PENDING.md mentioning that we did this?

(PENDING.md will be copied into CHANGELOG.md when we cut a release)

ValarDragon
ValarDragon approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: 💯 🍰 ⭐

cwgoes
cwgoes approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks!

@cwgoes cwgoes merged commit 831435c into cosmos:develop Aug 10, 2018
@alessio alessio deleted the alessio/1930-defaults-turn-indexing-on branch September 6, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @faboweb @cwgoes @ValarDragon