Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API module rework #18847

Closed
3 tasks
julienrbrt opened this issue Dec 20, 2023 · 3 comments
Closed
3 tasks

API module rework #18847

julienrbrt opened this issue Dec 20, 2023 · 3 comments
Labels
T:Epic Epics

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Dec 20, 2023

Having a global API module for separately versioned modules isn't correct.
<To elaborate>

Work breakdown

ref: #12003


Once this issue is closed, we will be able to backport #18473

@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Dec 20, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Dec 20, 2023
@julienrbrt julienrbrt added T:Epic Epics and removed needs-triage Issue that needs to be triaged labels Dec 20, 2023
@tac0turtle
Copy link
Member

before the final step we should get an adr which defines what are the rules around protobuf we are adhering to. We dont follow protobuf rules and the mix of following and not following is causing issues. We should squash this once and for all

@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 6, 2024

Maybe we don't need an api module at all, and solely use buf autogenerated code: https://buf.build/docs/bsr/generated-sdks/go with the https://buf.build/protocolbuffers/go plugin.

@julienrbrt
Copy link
Member Author

julienrbrt commented Feb 20, 2024

Closing this until we have an actual proposal. We can get away long enough by using buf.build generated sdk and setup buf plugin and improve our buf usage altogether (#19503)

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Feb 20, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Epic Epics
Projects
None yet
Development

No branches or pull requests

2 participants