-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baseapp: Should routes allow numbers #1587
Comments
Yeah I agree - I don't see the problem |
Could we also allow backlashes? Would be nice to namespace message types by module. Ex: |
That ties into #770 I prefer we don't allow that now. I would rather not have peoples routes silently break in a future sdk upgrade. |
ValarDragon
added a commit
that referenced
this issue
Jul 17, 2018
Previously only alphabetic characters were allowed. Closes #1587
8 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ref #1579 (comment)
Previously we had an error saying they were alphanumeric, but were actually only allowing alphabetic. The error has been changed to reflect that the routes should be alphabetic. However, I think we should allow numerics in routes. Conceivably, a module could want several similarly named modules / several modules with slight alterations running together, and numerics are a convenient way to do this.
I don't see any downside from adding numbers, other than possible
1, l
andO, 0
ambiguity.The text was updated successfully, but these errors were encountered: