Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting events with api types leaves the Type field blank in sdk.Event #13022

Closed
technicallyty opened this issue Aug 24, 2022 · 2 comments
Closed

Comments

@technicallyty
Copy link
Contributor

technicallyty commented Aug 24, 2022

Summary of Bug

If you pass a type from the api package to EmitTypedEvent, the underlying attributes get filled, but the type field is left blank.

I did also discover that ParseTypedEvent fails with pulsar types. Should we add more compat for these types or just recommend not to use pulsar types in events?

Version

149787b

Steps to Reproduce

  1. pass pulsar type to EmitTypedEvent
  2. get event from event manager
  3. see Type field is blank
@aaronc
Copy link
Member

aaronc commented Aug 30, 2022

There is no support for pulsar types via EmitTypedEvent so this is expected. I'm surprised it works at all

@aaronc
Copy link
Member

aaronc commented Aug 30, 2022

There is an open issue for this #11278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants