-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use google.golang.org/protobuf messages in typed events #11278
Comments
It we do this correctly, it should allow us to resolve any performance issues associated with JSON marshaling for typed events. We may even want to consider deprecating gogo support because of this. The key thing is being able to iterate over the fields in a deterministic way which |
Would rather sort the fields rather than rely on Pulsar. |
I think we can support both options |
i think if someone is sending events to tendermint they should not assume it doesnt come with a little overhead |
closing as we decided to deal with one proto type for now in the state machine |
We can do a type switch in
TypedEventToEvent
to see if we have a newproto.Message
. Then we can use theprotoreflect.Message.Range
method to convert the event to an ABCI event rather than marshaling to JSON in the middle. This should be more efficient than the current method and also allow us to store unquoted strings in attribute values (rather than what happens now with JSON).Probably
ParseTypedEvent
should decode to a newproto.Message
if one exists.The text was updated successfully, but these errors were encountered: