Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency from codec -> simapp #12528

Closed
Tracked by #11899
kocubinski opened this issue Jul 11, 2022 · 0 comments · Fixed by #12530
Closed
Tracked by #11899

Remove dependency from codec -> simapp #12528

kocubinski opened this issue Jul 11, 2022 · 0 comments · Fixed by #12530
Assignees

Comments

@kocubinski
Copy link
Member

kocubinski commented Jul 11, 2022

This is a subsection of a much larger dependency pattern, usages of simapp.MakeTestEncodingConfig, which is how this dependency is expressed in codec.

@kocubinski kocubinski changed the title codec Remove dependency from codec -> simapp Jul 11, 2022
@kocubinski kocubinski self-assigned this Jul 11, 2022
@kocubinski kocubinski moved this to 📝 Todo in Cosmos-SDK Jul 11, 2022
@mergify mergify bot closed this as completed in #12530 Jul 11, 2022
mergify bot pushed a commit that referenced this issue Jul 11, 2022
## Description

Closes: #12528



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant