Skip to content

Commit

Permalink
Merge branch 'master' into dependabot/go_modules/github.com/cosmos/co…
Browse files Browse the repository at this point in the history
…smos-sdk/errors-1.0.0-beta.4
  • Loading branch information
likhita-809 authored Mar 30, 2022
2 parents 94f1039 + e3c3467 commit ee6e6bc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/auth) [\#10880](https://github.com/cosmos/cosmos-sdk/pull/10880) Added a new query to the tx query service that returns a block with transactions fully decoded.
* (types) [\#11200](https://github.com/cosmos/cosmos-sdk/pull/11200) Added `Min()` and `Max()` operations on sdk.Coins.
* (gov) [\#11287](https://github.com/cosmos/cosmos-sdk/pull/11287) Fix error message when no flags are provided while executing `submit-legacy-proposal` transaction.
* (x/auth) [\#11482](https://github.com/cosmos/cosmos-sdk/pull/11482) Improve panic message when attempting to register a method handler for a message that does not implement sdk.Msg

### Bug Fixes

Expand Down
4 changes: 4 additions & 0 deletions contrib/devtools/dockerfile → contrib/devtools/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## To test locally:
# docker build --pull --rm -f "contrib/devtools/Dockerfile" -t cosmossdk-proto:latest "contrib/devtools"
# docker run -v $(pwd):/workspace --workdir /workspace cosmossdk-proto sh ./scripts/protocgen.sh

FROM bufbuild/buf:1.1.0 as BUILDER

FROM golang:1.17-alpine
Expand Down
2 changes: 1 addition & 1 deletion x/auth/middleware/msg_service_router.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (msr *MsgServiceRouter) RegisterService(sd *grpc.ServiceDesc, handler inter
// We panic here because there is no other alternative and the app cannot be initialized correctly
// this should only happen if there is a problem with code generation in which case the app won't
// work correctly anyway.
panic(fmt.Errorf("can't register request type %T for service method %s", i, fqMethod))
panic(fmt.Errorf("unable to register service method %s: %T does not implement sdk.Msg", fqMethod, i))
}

requestTypeName = sdk.MsgTypeURL(msg)
Expand Down

0 comments on commit ee6e6bc

Please sign in to comment.