fix: dockerfile for building proto (#11452) (#11703)

* fix: dockerfile for building proto (#11452)

github.com/regen-network/cosmos-proto/protoc-gen-gocosmos was missing in the Dockerfile

* fixed the installation with proto cosmos
* updated dependencies
* set the go version to 1.17 (latest is already using 1.18)
* regenerated proto

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

* update dockerfile

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Makefile

@@ -395,7 +395,7 @@ devdoc-update:
 ###                                Protobuf                                 ###
 ###############################################################################
 
-protoVer=v0.6
+protoVer=v0.7
 protoImageName=tendermintdev/sdk-proto-gen:$(protoVer)
 containerProtoGen=$(PROJECT_NAME)-proto-gen-$(protoVer)
 containerProtoGenAny=$(PROJECT_NAME)-proto-gen-any-$(protoVer)

contrib/devtools/Dockerfile

@@ -1,6 +1,6 @@
 ## To test locally:
 # docker build --pull --rm -f "contrib/devtools/Dockerfile" -t cosmossdk-proto:latest "contrib/devtools"
-# docker run -v $(pwd):/workspace --workdir /workspace cosmossdk-proto sh ./scripts/protocgen.sh
+# docker run --rm -v $(pwd):/workspace --workdir /workspace cosmossdk-proto sh ./scripts/protocgen.sh
 
 FROM bufbuild/buf:1.1.0 as BUILDER
 
@@ -17,15 +17,22 @@ ENV GOLANG_PROTOBUF_VERSION=1.28.0 \
   GRPC_GATEWAY_VERSION=1.16.0
 
 
-RUN go install github.com/cosmos/cosmos-proto/cmd/protoc-gen-go-pulsar@latest && \
-  go install google.golang.org/protobuf/cmd/protoc-gen-go@v${GOLANG_PROTOBUF_VERSION} && \
-  go install github.com/gogo/protobuf/protoc-gen-gogo@v${GOGO_PROTOBUF_VERSION} && \
-  go install github.com/gogo/protobuf/protoc-gen-gogofast@v${GOGO_PROTOBUF_VERSION} && \ 
-  go install github.com/gogo/protobuf/protoc-gen-gogofaster@v${GOGO_PROTOBUF_VERSION} && \
-  go install github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway@v${GRPC_GATEWAY_VERSION} && \
-  go install github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger@v${GRPC_GATEWAY_VERSION} && \
-  go install github.com/regen-network/cosmos-proto/protoc-gen-gocosmos@latest 
+RUN go install github.com/cosmos/cosmos-proto/cmd/protoc-gen-go-pulsar@latest
+RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v${GOLANG_PROTOBUF_VERSION}
+RUN go install github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway@v${GRPC_GATEWAY_VERSION} \
+    github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger@v${GRPC_GATEWAY_VERSION}
 
+# install all gogo protobuf binaries
+RUN git clone https://github.com/regen-network/protobuf.git; \
+    cd protobuf; \
+    go mod download; \
+    make install
+
+# we need to use git clone because we use 'replace' directive in go.mod
+# protoc-gen-gocosmos was moved to to in cosmos/gogoproto but pending a migration there.
+RUN git clone https://github.com/regen-network/cosmos-proto.git; \
+    cd cosmos-proto/protoc-gen-gocosmos; \
+    go install .
 
 RUN npm install -g swagger-combine
 

scripts/protocgen.sh

@@ -1,36 +1,24 @@
 #!/usr/bin/env bash
 
 #== Requirements ==
- #
- ## make sure your `go env GOPATH` is in the `$PATH`
- ## Install:
- ## + latest buf (v1.0.0-rc11 or later)
- ## + protobuf v3
- #
- ## All protoc dependencies must be installed not in the module scope
- ## currently we must use grpc-gateway v1
- # cd ~
- # go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
- # go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
- # go install github.com/grpc-ecosystem/grpc-gateway/[email protected]
- # go install github.com/cosmos/cosmos-proto/cmd/protoc-gen-go-pulsar@latest
- # go get github.com/regen-network/cosmos-proto@latest # doesn't work in install mode
+#
+## make sure your `go env GOPATH` is in the `$PATH`
+## Install:
+## + latest buf (v1.0.0-rc11 or later)
+## + protobuf v3
+#
+## All protoc dependencies must be installed not in the module scope
+## currently we must use grpc-gateway v1
+# cd ~
+# go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
+# go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
+# go install github.com/grpc-ecosystem/grpc-gateway/[email protected]
+# go install github.com/cosmos/cosmos-proto/cmd/protoc-gen-go-pulsar@latest
+# go get github.com/regen-network/cosmos-proto@latest # doesn't work in install mode
+# go get github.com/regen-network/cosmos-proto/[email protected]
 
 set -eo pipefail
 
-protoc_install_gocosmos() {
-   echo "Installing protobuf gocosmos plugin"
-   # we should use go install, but regen-network/cosmos-proto contains
-   # replace directives. It must not contain directives that would cause
-   # it to be interpreted differently than if it were the main module.
-   # So the command below issues a warning and we are muting it for now.
-   #
-   # Installing plugins must be done outside of the module
-   (go get github.com/regen-network/cosmos-proto/[email protected] 2> /dev/null)
- }
-
- protoc_install_gocosmos
-
 echo "Generating gogo proto code"
 cd proto
 proto_dirs=$(find ./cosmos -path -prune -o -name '*.proto' -print0 | xargs -0 -n1 dirname | sort | uniq)