Adjusting tests after reverting checks

cosmos · Feb 8, 2019 · b3c23b3 · b3c23b3
1 parent a48899e
commit b3c23b3
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 21 deletions.
diff --git a/client/context/broadcast.go b/client/context/broadcast.go
@@ -4,8 +4,6 @@ import (
 	"fmt"
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
-
-	"github.com/pkg/errors"
 )
 
 // BroadcastTx broadcasts a transactions either synchronously or asynchronously

diff --git a/client/keys/add_test.go b/client/keys/add_test.go
@@ -23,12 +23,8 @@ func Test_runAddCmdBasic(t *testing.T) {
 	cmd := addKeyCommand()
 	assert.NotNil(t, cmd)
 
-	// Empty
-	err := runAddCmd(cmd, []string{})
-	assert.EqualError(t, err, "not enough arguments")
-
 	// Missing input (enter password)
-	err = runAddCmd(cmd, []string{"keyname"})
+	err := runAddCmd(cmd, []string{"keyname"})
 	assert.EqualError(t, err, "EOF")
 
 	// Prepare a keybase

diff --git a/client/keys/delete_test.go b/client/keys/delete_test.go
@@ -25,10 +25,6 @@ func Test_runDeleteCmd(t *testing.T) {
 	fakeKeyName1 := "runDeleteCmd_Key1"
 	fakeKeyName2 := "runDeleteCmd_Key2"
 
-	err := runDeleteCmd(deleteKeyCommand, []string{})
-	require.Error(t, err)
-	require.Equal(t, "a name must be provided", err.Error())
-
 	// Now add a temporary keybase
 	kbHome, cleanUp, err := tests.GetTempDir("Test_runDeleteCmd")
 	assert.NoError(t, err)

diff --git a/client/keys/show_test.go b/client/keys/show_test.go
@@ -38,10 +38,7 @@ func Test_showKeysCmd(t *testing.T) {
 func Test_runShowCmd(t *testing.T) {
 	cmd := showKeysCmd()
 
-	err := runShowCmd(cmd, []string{})
-	assert.EqualError(t, err, "not enough arguments")
-
-	err = runShowCmd(cmd, []string{"invalid"})
+	err := runShowCmd(cmd, []string{"invalid"})
 	assert.EqualError(t, err, "Key invalid not found")
 
 	err = runShowCmd(cmd, []string{"invalid1", "invalid2"})

diff --git a/client/keys/update_test.go b/client/keys/update_test.go
@@ -26,11 +26,8 @@ func Test_runUpdateCmd(t *testing.T) {
 
 	cmd := updateKeyCommand()
 
-	err := runUpdateCmd(cmd, []string{})
-	assert.EqualError(t, err, "not enough arguments")
-
 	// fails because it requests a password
-	err = runUpdateCmd(cmd, []string{fakeKeyName1})
+	err := runUpdateCmd(cmd, []string{fakeKeyName1})
 	assert.EqualError(t, err, "EOF")
 
 	cleanUp := client.OverrideStdin(bufio.NewReader(strings.NewReader("pass1234\n")))

diff --git a/tests/test_cover.sh b/tests/test_cover.sh
@@ -5,8 +5,6 @@ PKGS=$(go list ./... | grep -v /vendor/ | grep -v github.com/cosmos/cosmos-sdk/c
 
 set -e
 echo "mode: atomic" > coverage.txt
-for pkg in ${PKGS}; do
-    go test -v -timeout 30m -race -coverprofile=profile.out -covermode=atomic "$pkg"
 for pkg in ${PKGS[@]}; do
     go test -v -timeout 30m -race -coverprofile=profile.out -covermode=atomic -tags='ledger test_ledger_mock' "$pkg"
     if [ -f profile.out ]; then