Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
JulianToledano committed May 16, 2024
1 parent 8ca5ad1 commit 9868c7f
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
9 changes: 6 additions & 3 deletions codec/address/bech32_codec_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,18 @@ import (
"github.com/cosmos/cosmos-sdk/internal/conv"
)

func generateAddresses(totalAddresses int) [][]byte {
func generateAddresses(totalAddresses int) ([][]byte, error) {
keys := make([][]byte, totalAddresses)
addr := make([]byte, 32)
for i := 0; i < totalAddresses; i++ {
rand.Read(addr)
_, err := rand.Read(addr)
if err != nil {
return nil, err
}
keys[i] = addr
}

return keys
return keys, nil
}

func TestNewBech32Codec(t *testing.T) {
Expand Down
4 changes: 3 additions & 1 deletion codec/address/bench_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package address

import (
"github.com/stretchr/testify/require"
"testing"

"github.com/stretchr/testify/assert"
Expand All @@ -20,7 +21,8 @@ func BenchmarkCodecWithoutCache(b *testing.B) {

func bytesToString(b *testing.B, cdc address.Codec) {
b.Helper()
addresses := generateAddresses(10)
addresses, err := generateAddresses(10)
require.NoError(b, err)

b.Helper()
b.ReportAllocs()
Expand Down
8 changes: 6 additions & 2 deletions codec/address/fuzz_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ func FuzzCachedAddressCodec(f *testing.F) {
f.Skip()
}

addresses := generateAddresses(2)
addresses, err := generateAddresses(2)
require.NoError(f, err)

for _, addr := range addresses {
f.Add(addr)
}
Expand All @@ -31,7 +33,9 @@ func FuzzAddressCodec(f *testing.F) {
if testing.Short() {
f.Skip()
}
addresses := generateAddresses(2)
addresses, err := generateAddresses(2)
require.NoError(f, err)

for _, addr := range addresses {
f.Add(addr)
}
Expand Down

0 comments on commit 9868c7f

Please sign in to comment.