Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tac0turtle committed Jun 12, 2024
1 parent 2366d2c commit 7f469d2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion x/gov/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ they don't vote themselves.
deposits if the proposal was accepted or rejected. If the proposal was vetoed, or never entered voting period (minimum deposit not reached within deposit period), the deposit is burned.

This module is in use on the Cosmos Hub (a.k.a [gaia](https://github.com/cosmos/gaia)).
Features that may be added in the future are described in [Future Improvements](#future-improvements).


## Contents

Expand Down
8 changes: 0 additions & 8 deletions x/gov/keeper/abci.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import (

"github.com/cosmos/cosmos-sdk/telemetry"
sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
)

// EndBlocker is called every block.
Expand Down Expand Up @@ -210,13 +209,6 @@ func (k Keeper) EndBlocker(ctx context.Context) error {
return nil
})

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
if err != nil {
// update proposal if error is out of gas
if errors.Is(err, sdkerrors.ErrOutOfGas) {
proposal.Status = v1.StatusFailed
proposal.FailedReason = err.Error()
tagValue = types.AttributeValueProposalFailed
logMsg = "passed proposal failed due to out of gas"
}
// `idx` and `err` are populated with the msg index and error.
proposal.Status = v1.StatusFailed
proposal.FailedReason = err.Error()
Expand Down

0 comments on commit 7f469d2

Please sign in to comment.