cl++

cosmos · Oct 23, 2023 · 4efd5e9 · 4efd5e9
1 parent 53d9050
commit 4efd5e9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/math/CHANGELOG.md b/math/CHANGELOG.md
@@ -42,6 +42,7 @@ Ref: https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.j
 
 ### Bug Fixes
 
+* [#18214](https://github.com/cosmos/cosmos-sdk/pull/18214) Ensure that modifying the argument to `NewUIntFromBigInt` doesn't mutate the returned value.
 * [#17725](https://github.com/cosmos/cosmos-sdk/pull/17725) Fix state break in ApproxRoot. This has been present since math/v1.0.1. It changed the rounding behavior at precision end in an intermediary division from banker's to truncation. The truncation occurs from binary right shift in the case of square roots. The change is now reverted back to banker's rounding universally for any root.
 
 ## [math/v1.1.2](https://github.com/cosmos/cosmos-sdk/releases/tag/math/v1.1.2) - 2023-08-21

diff --git a/math/uint.go b/math/uint.go
@@ -235,7 +235,6 @@ func checkNewUint(i *big.Int) (Uint, error) {
 	if err := UintOverflow(i); err != nil {
 		return Uint{}, err
 	}
-
 	return Uint{new(big.Int).Set(i)}, nil
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -235,7 +235,6 @@ func checkNewUint(i *big.Int) (Uint, error) { @@
     	if err := UintOverflow(i); err != nil {
     		return Uint{}, err
     	}
     	return Uint{new(big.Int).Set(i)}, nil
     }
@@ Expand Down @@