Merge pull request #2666 from cosmos/alessio/2664-fix-dns-alt-name

[R4R] Include DNS alt name in certificate
cosmos · Nov 2, 2018 · 22ef944 · 22ef944
2 parents b6443e9 + a0a6bad
commit 22ef944
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/client/lcd/certificates.go b/client/lcd/certificates.go
@@ -38,12 +38,13 @@ func generateSelfSignedCert(host string) (certBytes []byte, priv *ecdsa.PrivateK
 		Subject: pkix.Name{
 			Organization: []string{"Gaia Lite"},
 		},
+		DNSNames:              []string{"localhost"},
 		NotBefore:             notBefore,
 		NotAfter:              notAfter,
 		KeyUsage:              x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature | x509.KeyUsageCertSign,
 		ExtKeyUsage:           []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth},
 		BasicConstraintsValid: true,
-		IsCA: true,
+		IsCA:                  true,
 	}
 	hosts := strings.Split(host, ",")
 	for _, h := range hosts {

diff --git a/client/lcd/certificates_test.go b/client/lcd/certificates_test.go
@@ -17,7 +17,7 @@ func TestGenerateSelfSignedCert(t *testing.T) {
 	cert, err := x509.ParseCertificate(certBytes)
 	require.Nil(t, err)
 	require.Equal(t, 2, len(cert.IPAddresses))
-	require.Equal(t, 1, len(cert.DNSNames))
+	require.Equal(t, 2, len(cert.DNSNames))
 	require.True(t, cert.IsCA)
 }