Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mitigate auction front-running (VE) #91

Closed
wants to merge 6 commits into from
Closed

Conversation

samricotta
Copy link
Contributor

@samricotta samricotta commented Nov 27, 2023

Tutorial for implementation of Vote Extensions. Uses https://github.com/fatal-fruit/abci-workshop. This will be moved across to the sdk-tutorials repo next week but for now will point to the original repo that was used for the workshop

Closes: #90

@samricotta samricotta marked this pull request as ready for review November 27, 2023 21:04
@tac0turtle
Copy link
Member

im kind of confused by this pr, its unclear if its a tutorial or a walkthrough of something already existing? Who is the audience for this tutorial as well? Advanced users or beginners?

@facundomedica
Copy link
Member

Who is the audience for this tutorial as well? Advanced users or beginners?

I think the audience is more advanced users, because to be able to use vote extensions you need to already know lots of other things prior to this


## Simulation of Auction Front-Running

To verify an occurrence of front-running, you can navigate to the logs and search for instances of `💨 :: Found a Bid to Snipe`. This specific log message indicates that the validator has identified a bid to potentially front-run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line maybe needs to be removed or moved a few paragraphs below, as it's something you are later instructed to do


## Context

For this tutorial we are using an example of an application that is mitigating auction front-running.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we expand a little bit on what the example application does? Explain beforehand that the application is an auctioning of namespaces, just a couple of lines is fine.


Front-running is a potential issue in blockchain systems where a participant gains an advantage by being able to perform actions or transactions ahead of others. In the context of this application, front-running can occur when a validator, who is also a proposer, spots a bid in the mempool and replaces it with their own higher bid. This is also known as "bid sniping".

Please checkout https://github.com/fatal-fruit/abci-workshop to see the example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get this migrated to the tutorial repo? we usually wouldnt allow this sort of linking for something we will end up hosting in the tutorial repo get merged as it will cause confusion later on.

we should also mention that the tutorial is in that repo and this walkthrough is assuming you have gone through the tutorial.

@samricotta samricotta closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

Migrate workshop steps to tutorials - Mitigate front running
3 participants