Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update tutorials #89

Closed
wants to merge 1 commit into from
Closed

refactor: Update tutorials #89

wants to merge 1 commit into from

Conversation

samricotta
Copy link
Contributor

Setting up a preliminary tutorials tab to link to individual tutorials to be able to insert new tutorials in easily

Part of #84

@samricotta samricotta self-assigned this Nov 21, 2023
@julienrbrt
Copy link
Member

Could you post a screenshot?

@samricotta
Copy link
Contributor Author

Screenshot 2023-11-21 at 14 05 46

{
type: "link",
label: "Run a Cosmos Chain with Ignite CLI",
href: "https://tutorials.cosmos.network/hands-on-exercise/1-ignite-cli/",
Copy link
Member

@julienrbrt julienrbrt Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to include this because it points to ignite v0.22 which is severely outdated.
With Ignite v28 with v0.50 support, I don't think we should link to outdated content but instead Ignite documentation directly that is already updated.

https://docs.ignite.com/nightly/guide for now and then should be updated once Ignite is tagged (should be soon afaik).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, this is true. I will wait then and just include my changes for the tutorials

{
type: "link",
label: "Run a Cosmos Chain with Ignite CLI",
href: "https://tutorials.cosmos.network/hands-on-exercise/1-ignite-cli/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

{
type: "link",
label: "Run a Cosmos Chain with Ignite CLI",
href: "https://tutorials.cosmos.network/hands-on-exercise/1-ignite-cli/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@julienrbrt
Copy link
Member

Why does it need to be repeated 3 times? 🤔

@samricotta
Copy link
Contributor Author

Repeated so that it lives on all pages, probably should just live on learn but I dont want it to get lost in there. Eventually I think having it at the top as a tab when we have more content @julienrbrt

@samricotta samricotta closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

2 participants