Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewBatchWithSize to DB interface #64

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Conversation

catShaark
Copy link
Collaborator

Closes: #63

  • This PR add new method for creating pre-allocated batch to DB interface.
  • Currently, there's only goleveldb that supports pre-allocating batch. @p0mvn said we should add the method anyway and have all the other db whose batch doesn't support pre-allocation create new empty batch without allocation for NewBatchWithSize.

@catShaark
Copy link
Collaborator Author

catShaark commented Dec 17, 2022

should I edit the CHANGLOG.md ?

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please could you add a chnaglog

@catShaark
Copy link
Collaborator Author

CHANGELOG added

@tac0turtle tac0turtle merged commit cc5ba75 into main Dec 22, 2022
@tac0turtle tac0turtle deleted the new-batch-with-size branch December 22, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add NewBatchWithSize to DB interface
2 participants