fix(amino/coin): ibc denoms should be parsable #1536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change you are referring to is for Unfortunately the diff is hard to review and introduces decimal amounts without any additional test. Will close this and add IBC support to parseCoins in a deparate PR. |
|
Done in #1554. Turns out, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied same regex as 643bf25#diff-9136eafb27b821610a184d11b99ace152206c81924606263f9443a75ff2865aeR28.
ps: the commit specifies that it has been merged into main and yet I don't see any changes in version v0.32.2 either via npm or this github repository.