Skip to content

Commit

Permalink
multisigs and data as string
Browse files Browse the repository at this point in the history
  • Loading branch information
JulianToledano committed Nov 3, 2023
1 parent 3b43d3b commit 234e774
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions cips/cip-X.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ The first message added to the `offchain` package is `MsgSignArbitraryData`.

`MsgSignArbitraryData` enables developers to sign arbitrary bytes that are valid only in an off-chain context. Here,
`AppDomain` represents the application requesting off-chain message signing, while `signerAddress` is the account address of
the signer. `Data` consists of arbitrary bytes that can represent various forms of data, including text, files, or
the signer. `Data` consists of a string with valid UTF-8 text that can represent various forms of data, including text, files, or
objects. The decision on how to deserialize, serialize, and interpret `Data` is left to the application developers,
depending on their specific use case. It is important to note that some signers are not capable of signing
arbitrary-length messages.
Expand All @@ -111,7 +111,7 @@ message MsgSignArbitraryData {
// Signer is the sdk.AccAddress of the message signer
string signerAddress = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"];
// Data represents the raw bytes of the content that is signed (text, json, etc)
bytes data = 3 [(gogoproto.jsontag) = "data"];
string data = 3 [(gogoproto.jsontag) = "data"];
}
```

Expand Down Expand Up @@ -221,7 +221,7 @@ everything that needs to be verified on-chain, but it is for off-chain. If a sig
that be verified off-chain? Even if the message is enriched with a `chain-id` field, who is responsible for matching
`chain-id` and the node's IP?

Doesn't work with multisig accounts.
It'd work with current multisigs as they are deterministic but on chain multisigs would not work here.

## Rationale

Expand Down Expand Up @@ -262,9 +262,6 @@ Backwards compatibility is guaranteed as this CIP introduces new messages but do

## Security Considerations

It is important to notice that the `Data` field in `MsgSignArbitraryData` consists of bytes, which means it could be
non-human-readable.

There are no more security considerations as the messages will not be on-chain.

## Future Possibilities
Expand Down

0 comments on commit 234e774

Please sign in to comment.