Feat/clients #145
Feat/clients #145
Conversation
| return promise.then(data => QueryModuleAccountsResponse.decode(new _m0.Reader(data))); | ||
| } | ||
|
|
||
| Bech32Prefix(request: Bech32PrefixRequest): Promise<Bech32PrefixResponse> { |
There was a problem hiding this comment.
@assafmo I noticed that the version in cosmjs didn't' have Bech32Prefix and AddressBytesToString — I'm guessing this is still correct. Does it look ok to you?
There was a problem hiding this comment.
These queries are new in cosmos-sdk v0.46: https://github.com/cosmos/cosmos-sdk/blob/5019459b1b2028119c6ca1d80714caa7858c2076/proto/cosmos/auth/v1beta1/query.proto#L37-L64
We should probably have a registry of protobuf derived ts definitions for every tagged version of every chain, tendermint, ibc-go, cosmos-sdk, liquidity-staking-module, etc.
There was a problem hiding this comment.
Then decouple the client code from these definitions. Have the client devs import the definitions of the chain that they're targeting.
There was a problem hiding this comment.
great catch! ok so this is correct but it's for the 0.46.
sounds like a good plan to support all the tagged versions. Now you got me thinking... in future we may have a situation where an app wants to use two chains, and one uses 0.45 and the other 0.46 and we need to support both in the same process.
There was a problem hiding this comment.
an example use case: keplr governance UI and a user needs to vote. One chain uses 0.45 and another 0.46, my guess is, they'd need to have both cosmos versions.
I will continue to ponder the best way to support this. I'm almost inclined to just require the dev to make two different folders manually, although I can imagine a neat way to seamlessly allow the transpiler to bundle all the versions.
No description provided.