-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A hierarchy of types #48
Conversation
@ntessore, I had to change the name of the Hubble and critical density aggregate protocols and I am not thrilled with the new name. Perhaps we should systematize the naming structure a little better:
What would be nice is to have a consistent name with |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 77.16% 81.56% +4.40%
==========================================
Files 13 13
Lines 289 358 +69
==========================================
+ Hits 223 292 +69
Misses 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement! Needs a couple of fixes, nothing major.
I named it |
fb17673
to
d8ac31b
Compare
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Co-authored-by: Nicolas Tessore <[email protected]> Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question whether HoverH0
was intentional or typo, but LGTM!
Fine grain protocols of attrs and methods.
PR Checklist
CHANGES.rst
file. See existing changelog for examples.docs
folder.