Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants method #45

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Apr 11, 2023

A convenience method to access the constants used by the cosmology.
I've been using the API and this has been a pain point.

PR Checklist

  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added this to the v0.1 milestone Apr 11, 2023
@nstarman nstarman requested a review from ntessore April 11, 2023 17:09
@nstarman nstarman marked this pull request as ready for review April 11, 2023 17:10
@nstarman nstarman force-pushed the constants-attr branch 2 times, most recently from 7e7d0e5 to bff88d9 Compare April 11, 2023 18:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #45 (61f160a) into main (917f2cb) will decrease coverage by 0.04%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   77.19%   77.16%   -0.04%     
==========================================
  Files          13       13              
  Lines         285      289       +4     
==========================================
+ Hits          220      223       +3     
- Misses         65       66       +1     
Impacted Files Coverage Δ
src/cosmology/api/_core.py 80.00% <60.00%> (-1.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nstarman nstarman force-pushed the constants-attr branch 2 times, most recently from 8815ac5 to d92fb93 Compare April 13, 2023 16:27
@nstarman nstarman merged commit 424d54b into cosmology-api:main Apr 13, 2023
@nstarman nstarman deleted the constants-attr branch April 13, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants