-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename FLRW to HasDistanceFunctions #38
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 76.61% 76.78% +0.16%
==========================================
Files 13 13
Lines 278 280 +2
==========================================
+ Hits 213 215 +2
Misses 65 65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
41a5879
to
202035c
Compare
@ntessore, where do you think we should move the non-distance measure attributes/methods? |
Signed-off-by: nstarman <[email protected]>
202035c
to
a7445c2
Compare
I'm hesitant to put anything on |
Signed-off-by: nstarman <[email protected]>
I think one more doesn't hurt, |
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Done. Also, I folded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to look finished. I think we could stick all of the HasX
protocols into a single module (even just _components
) if that made future classification easier (is that a component? distance-related? extra? see Tcmb) but that's an infinitesimal change.
Agreed! I think we need some documentation and a meeting to go over everything and make sure we're happy with v0.1.
I agree |
I forgot to add |
Signed-off-by: nstarman <[email protected]>
TODO:
Some methods need to be broken out.
Otot0
(will also be renamed toOmega_tot0
)critical_density0
?Otot
Also:
HasDistanceMeasures
?PR Checklist
CHANGES.rst
file. See existing changelog for examples.docs
folder.