Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename O<x> to Omega_<x> #37

Merged
merged 1 commit into from
Mar 8, 2023
Merged

rename O<x> to Omega_<x> #37

merged 1 commit into from
Mar 8, 2023

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Mar 8, 2023

Follows the heuristic of intuitive naming.

PR Checklist

  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added this to the v0.1 milestone Mar 8, 2023
@nstarman nstarman requested a review from ntessore March 8, 2023 19:53
@nstarman nstarman marked this pull request as ready for review March 8, 2023 19:53
@codecov-commenter
Copy link

Codecov Report

Merging #37 (53e93fe) into main (9666120) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files          13       13           
  Lines         277      277           
=======================================
  Hits          212      212           
  Misses         65       65           
Impacted Files Coverage Δ
src/cosmology/api/_background.py 68.42% <100.00%> (ø)
src/cosmology/api/_components.py 86.79% <100.00%> (ø)
src/cosmology/api/_standard.py 89.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nstarman
Copy link
Contributor Author

nstarman commented Mar 8, 2023

I think this PR is ready.

@nstarman nstarman merged commit f95f02d into main Mar 8, 2023
@nstarman nstarman deleted the rename_O_to_Omega branch March 8, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants