-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split flrw protocol into pure and standard #18
Conversation
Signed-off-by: nstarman <[email protected]>
Thinking more about the naming, and what we really want to achieve with this API. I like the "standard" name, we could go even further and call it "StandardCosmology" without qualifier. I think that fits the spirit of the interface, which doesn't follow a strict model delineation like LCDM, wCDM, w0waCDM, etc. but instead simply has all the "standard" components. Along the same lines, the idea behind "FLRWCosmology" is also not so much about strict adherence to the FLRW model, but rather to have a smaller interface that deals purely with the general-relativistic background equations. So one could and say that the FLRW interface could be called "BackgroundCosmology". Trying to apply that taxonomy to the codes on my desk, it would work quite well. For example, I can immediately see three use cases:
I am not saying we should adopt these names necessarily, but there seems to be a clear semantic difference between the kinds of interfaces we want to provide, and I think we should make this distinction immediately obvious to users. |
Merging because this is blocking some other PRs. We can change the exact names later. |
My GH keeps on not updating every when I refresh. I missed this comment. |
No problem, I think we sent our respective comments at the exact same second. Mine is more of a meta-comment than a comment on this PR specifically. |
Followup PR: I like the names |
This way we can stick intermediate classes between Background and Standard, e.g. with inhomogeneity, where a global curvature parameter is less meaningful. |
Signed-off-by: nstarman [email protected]
Description
This pull request is to address ...
Fixes #
PR Checklist
CHANGES.rst
file. See existing changelog for examples.docs
folder.