Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sharing workspaces #842

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

jlandowner
Copy link
Member

Close #51

  • Add allowedUsers in network rule
  • Update authorization to allow users who can access at least 1 network rule can get the workspace information
  • Update authorization to allow users who can access its main network rule can update the workspace
  • Update UI to show shared workspaces

- Add allowedUsers in network rule
- Update authorization to allow users who can access at least 1 network rule can get the workspace information
- Update authorization to allow users who can access its main network rule can update the workspace
- Update UI to show shared workspaces
@jlandowner jlandowner added enhancement New feature or request controller-manager Controller Manager dashboard Dashboard server and UI traefik-plugins traefik-plugins labels Jun 19, 2024
@jlandowner jlandowner requested a review from oruharo June 19, 2024 14:05
@@ -77,6 +87,7 @@
}

func (p *CosmoAuth) ServeHTTP(w http.ResponseWriter, r *http.Request) {
LoggerDEBUG.Printf("%s %s %s: headers=%v", r.RemoteAddr, r.Method, r.URL, r.Header)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

Sensitive data returned by HTTP request headers
flows to a logging call.
@oruharo oruharo merged commit 0bf903d into cosmo-workspace:main Jun 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller-manager Controller Manager dashboard Dashboard server and UI enhancement New feature or request traefik-plugins traefik-plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared workspaces
2 participants