Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve events #826

Merged
merged 3 commits into from
May 28, 2024
Merged

Improve events #826

merged 3 commits into from
May 28, 2024

Conversation

jlandowner
Copy link
Member

  • Add events when template is updated
  • Fix cluster-scoped events for users occurs in default namespace

@jlandowner jlandowner added improvement Improvement for existing feature controller-manager Controller Manager labels May 28, 2024
@jlandowner jlandowner requested a review from oruharo May 28, 2024 11:59
@oruharo oruharo merged commit 60928af into cosmo-workspace:main May 28, 2024
3 checks passed
@jlandowner jlandowner mentioned this pull request May 29, 2024
Closed
@jlandowner jlandowner linked an issue May 29, 2024 that may be closed by this pull request
Events emited by Addon's ClusterInstance are not shown in cosmoctl get events #824
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruharo oruharo oruharo approved these changes

Assignees
No one assigned
Labels
controller-manager Controller Manager improvement Improvement for existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events emited by Addon's ClusterInstance are not shown in cosmoctl get events
2 participants
@jlandowner @oruharo