-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR with Earth occultation #258
Merged
GallegoSav
merged 17 commits into
cositools:develop
from
ckarwin:develop-Earth_Occultation
Oct 25, 2024
Merged
PSR with Earth occultation #258
GallegoSav
merged 17 commits into
cositools:develop
from
ckarwin:develop-Earth_Occultation
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
Ok, I fixed some bugs, and all checks have passed for unit tests. |
GallegoSav
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the scatt map to include Earth occultation. The ori file now needs to include columns for altitude and Earth zenith (i.e. spacecraft location). Moreover, the scatt map should only be calculated for a single source position, and likewise for the point source response. Essentially, when filling the scatt map histogram, the code sets the weights to zero for pointings where the source is blocked by Earth.
I added a simple example notebook in the response tutorial directory where I tested the changes. Everything seems to be working. As a simple test, I placed a point source at the Galactic center, and made an ori file where the instrument points to the Galactic center for 30 seconds. For the first 15 seconds the instrument is in front of Earth, and for the second 15.1 seconds it's behind earth. Summing the scatt map gives a total exposure time of 15.1 seconds, as expected.