fix(dependencies): constrain scipy version to <=1.13.0 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest update of scipy has deprecated the 'trapz' function in favor of 'trapezoid', which breaks dependencies and tests. The affected dependencies are 3ML and speclite. This commit restricts the scipy version to 1.13.0 or lower to maintain compatibility and ensure tests pass.
|
Thanks, @krishnatejavedula! The tests are passing, it worked. I'll merge this is a bit. Can you please open an accompanying issue reminds us to revert this when speclite has a new release? |
|
@israelmcmc, I have opened an issue regarding this. Issue #193 |
|
Thanks, @krishnatejavedula! I'm merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest update of
scipyscipy.integrate.trapzhas been removed in favour oftrapezoid, which breaks some dependencies and tests. The affected dependencies are 3ML and speclite. This commit restricts thescipyversion to 1.13.0 or lower to maintain compatibility and ensure tests pass.