-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installation for Python 3.11 #187
Conversation
Hi @israelmcmc. I tested the change, the installation was successfully (except installing h5py by It seems related to the logging of astromodels. Could you please test on your side? I never saw this before, and I am not sure if it's specific to my M1 mac. Thank you!
|
Thanks for checking this, @Yong2Sheng. I confirm that I can reproduce your error. I'll need to poke into this to find out what's causing it. |
Related to threeML/astromodels#201 |
… Also, interpolation now fixed this other issue EconForge/interpolation.py#112, which allows to remove the restriction on numba (which is needed for astromodels 2.4.2)
@Yong2Sheng Can you give it another try, please? I'm now requiring a newer version of astromodels that fixes this issue. |
Hi @israelmcmc, I installed the package and successfully run through the TS map notebook, it went well. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed, tested the imports and ts map notebook. It went well. Thank you @israelmcmc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
I tracked down the issue it to pip resolving to a very old version of 3ML, which required a very old version of speclite, not compatible with recent Python versions.
I solved this simply by requiring a more recent version of 3ML, which is good anyway.
Closes #133