-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the axis order of coordsys conversion matrix / added doctring to image deconvolution classes #124
Conversation
…inates - cosipy/docs/tutorials/image_deconvolution/511keV/GalacticCDS/511keV-DC2-Galactic-ImageDeconvolution.ipynb - cosipy/docs/tutorials/image_deconvolution/Crab/GalacticCDS/Crab-DC2-Galactic-ImageDeconvolution.ipynb Also, I modified typos in previous notebooks.
…cAtt, NuLambda] to [Time/ScAtt, lb, NuLamnda]
I need to modify the notebooks for galactic CDS followed by the axis order change in the coordsys conversion matrix. In order not to make things complicated, I merged #120 into this pull request, and closed #120. The comment originally in #120 is here:
|
Hi @hiyoneda, I'm reviewing your notebook now. I ran through it on a server running Ubuntu 22.04.3, with 515G RAM. Here is a list of all the issues i encountered with the notebook; most are minor and have to do with the direct data download.
As you can see, these are all pretty trivial issues. Otherwise, everything works from scratch on my system. Great job! This is a fun notebook to review :) |
I ran Regarding the command to download the 511 keV data, I checked Wasabi file_manager as sub-user but I wasn't able to find the file. On the other hand, I was able to get I ran |
Thanks @fieldrog @KeigoOkuma! I modified the notebooks, considering your comments. All of your comments were reflected. Regarding downloading files, I have checked the file names and modified them to the latest ones. I tested the corresponding cells and confirmed that it works well now. The number of changed files is large in this PR, but most are due to adding docstring and minor changes on the notebooks. The thing that was not tested was the notebook with the galactic CDS, and now it has been checked that it works in some different environments. So, I think that this PR is ready to be merged into the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be reviewed after Chris's PR #114 is merged and closed