Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update the notebooks to use the new-format orientation file? #263

Open
hiyoneda opened this issue Nov 12, 2024 · 4 comments
Open

Comments

@hiyoneda
Copy link
Contributor

20280301_3_month.ori cannot be read now because the format is outdated.

@ckarwin I remember that you discussed it before, but I forgot the plan. Can you remind me how we can solve this; should we update all of the notebooks by using 20280301_3_month_modified.ori, or will the orientation file be modified to use the old format?

Screenshot 2024-11-11 at 17 28 32

@ckarwin
Copy link
Contributor

ckarwin commented Nov 12, 2024

@hiyoneda The plan was to update the notebooks with 20280301_3_month_modified.ori.

@israelmcmc
Copy link
Collaborator

Yeah, I agree. Similar comment as in #260

@ckarwin
Copy link
Contributor

ckarwin commented Nov 12, 2024

@hiyoneda @israelmcmc I'm working on updating some of the notebooks right now, also in response to issue #262 . Actually, I think instead of using 20280301_3_month_modified.ori, with three dummy columns of zero for the altitude and Earth zenith, we can just use the true values from the DC2 orientation. The notebooks will still need to be updated with the new ori file, but now the likelihood fit will correctly account for Earth occultation. I have also added an option in get_scatt_map (and COSILike) to include Earth occultation or not, with the default set to True.

@augustus-thomas
Copy link

Pull request #266 solves this issue in one of the notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants