Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using get_scatt_map from COSILike #262

Open
hiyoneda opened this issue Nov 12, 2024 · 2 comments
Open

Error when using get_scatt_map from COSILike #262

hiyoneda opened this issue Nov 12, 2024 · 2 comments

Comments

@hiyoneda
Copy link
Contributor

An error occurred when running the Crab spectral fitting notebook with the develop branch (f3a7477).
Probably, after some updates,self._sc_orientation.get_scatt_map needs target_coord as its input parameter now.

Screenshot 2024-11-11 at 17 40 08
@ckarwin
Copy link
Contributor

ckarwin commented Nov 12, 2024

@hiyoneda Yup, that's right. I can update this and make a PR. Can you check it when it's ready?

@hiyoneda
Copy link
Contributor Author

@hiyoneda Yup, that's right. I can update this and make a PR. Can you check it when it's ready?

yes, I'll check it.

This was referenced Nov 12, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
cosipy
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckarwin @hiyoneda